Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gommap dependency #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romanst-workato
Copy link

go get fails for specified dependency

go get fails for specified dependency
Copy link

@romain-gaillard romain-gaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cschar
Copy link

cschar commented Apr 22, 2023

Just encountered this same issue now , should have checked PRs first! Basically found this same resolution.

Merge!

@mfilipav
Copy link

just to piggy back off this, @romain-gaillard do you think we could easily replace tysonmote/gommap with the new mmap https://pkg.go.dev/github.com/go-mmap/mmap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants