Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse multi-line query fix #697

Closed
wants to merge 2 commits into from

Conversation

jnichols-git
Copy link
Member

#696 was describing an issue with multi-line queries in ClickHouse, where if a query started with SELECT immediately followed by a newline, it would not get cached. The parser previously only looked for SELECT or SELECT (including spaces), so this adds SELECT\n to the list. Also removed a make call that was unused.

@jnichols-git jnichols-git requested a review from jranson January 10, 2024 01:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7469111492

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 92.275%

Totals Coverage Status
Change from base Build 7109829312: -0.04%
Covered Lines: 17285
Relevant Lines: 18732

💛 - Coveralls

@jnichols-git
Copy link
Member Author

Whoops. Forgot to set DCO. Please hold.

@jnichols-git jnichols-git deleted the clickhouse-fix branch January 10, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants