Automate regeneration of PAM bindings #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
force-pushed
the
regenerate_pam_bindings
branch
6 times, most recently
from
9291e6e
to
d112b87
Compare
The tests generated directly by bindgen are useful as they cross-check the layout computed by the C compiler and by rustc. As they are not portable they were edited however in a way that basically exactly reproduces the layout algorithm rustc uses. This makes them ineffective at finding issues. At the same time they are manually written making automatic regeneration of the bindings in CI harder.
This will make it easier to compare generated bindings between platforms.
bjorn3
force-pushed
the
regenerate_pam_bindings
branch
from
d112b87
to
694f49a
Compare
squell
reviewed
Oct 15, 2024
squell
approved these changes
Oct 15, 2024
auto-merge was automatically disabled
October 15, 2024 13:39
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And check that they are up to date in CI. This will make it easier to add support for more platforms that each need their own PAM bindings.
Makes #869 easier to implement.