Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some spuriously failing tests and avoid deadlocks on test failure #899

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Nov 4, 2024

No description provided.

set_hook deadlocks if a thread in the fork parent was panicking at the
instant the fork happened. By using catch_unwind instead to handle the
panic this deadlock is avoided.
It previously didn't account for the process being in an uninterruptible
sleep.
@bjorn3
Copy link
Collaborator Author

bjorn3 commented Nov 4, 2024

Pushed what should be a fix for the spurious sigalrm_terminates_command test failures.

@bjorn3 bjorn3 changed the title Fix a spuriously failing test and avoid deadlocks on test failure Fix some spuriously failing tests and avoid deadlocks on test failure Nov 4, 2024
@squell squell merged commit 8e78c21 into trifectatechfoundation:main Nov 4, 2024
13 checks passed
@bjorn3 bjorn3 deleted the fix_test_fork_deadlock branch November 4, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants