Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin id to match change in package.json #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saoron
Copy link
Contributor

@saoron saoron commented Apr 30, 2019

Urgent!

the Id change to the standard cordova format is great but someone forgot to change this in the config.xml as well making the plugin uninstallable..

@arsenal942
Copy link
Collaborator

@tripflex You'll need to publish to npm so can you handle this PR please

@kalicki
Copy link

kalicki commented May 22, 2019

Up?!

@tripflex
Copy link
Owner

Related to #49

Basically when i first forked this plugin I didn't follow the standard of using cordova-plugin-XXXX in the naming, which is how it should be, so probably need to rename this repo to use the correct format of naming for the plugin

@tripflex
Copy link
Owner

Not really sure what the best way to handle this would be, for existing users using the WifiWizard2 to update for future users to use cordova-plugin-wifiwizard2 ... thoughts? @arsenal942 ? I guess we do need to update this when it's pushed to npm, so maybe create a separate branch specific for backwards compatibility, and use that branch when pushing to npm just making sure the name matches?

@arsenal942
Copy link
Collaborator

arsenal942 commented Jun 27, 2019

Not really sure what the best way to handle this would be, for existing users using the WifiWizard2 to update for future users to use cordova-plugin-wifiwizard2 ... thoughts? @arsenal942 ? I guess we do need to update this when it's pushed to npm, so maybe create a separate branch specific for backwards compatibility, and use that branch when pushing to npm just making sure the name matches?

@tripflex Late reply sorry. It won't impact their live/currently published applications so we COULD replace the existing branch and it is on the developers to simply re-install the plugin with the new Id. If we don't have a backwards compatible branch, all we would break is new builds where their build process will freak out about not finding the right plugin.

I'd be more inclined to do that otherwise developers will continue to use the 'backwards compatible' version and never update the Id to match.

@arsenal942
Copy link
Collaborator

@tripflex I am going to merge this. You will need to do what I said above after I merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants