-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few minor Lean misformalisations #210
Merged
Merged
Commits on Sep 9, 2024
-
This was disprovable because the key predicate did not quantify over all groups (and the goal was false even for the trivial group).
Configuration menu - View commit details
-
Copy full SHA for 8c3dbc1 - Browse repository at this point
Copy the full SHA 8c3dbc1View commit details -
The original form was disprovable because of quantifier confusion (e.g., taking `x` and `y` to be non-zero and constant gave a contradiction).
Configuration menu - View commit details
-
Copy full SHA for 69ca70d - Browse repository at this point
Copy the full SHA 69ca70dView commit details -
This was disprovable because the argument `ha : SDiff (Finset a)` allowed the user to fill in any function for the set difference function. So for example by providing a dummy set difference function that just always returned the empty set, the goal was false. Presumably this error arose because the original formaliser found that they could not use the existing set difference function out of the box. The right fix is either to put `open Classical` before the proof or to add the typeclass argument `[DecidableEq a]`. In the end I have provided rewrite since the original formalisation is a bit more complicated than it needs to be.
Configuration menu - View commit details
-
Copy full SHA for f1d6d78 - Browse repository at this point
Copy the full SHA f1d6d78View commit details -
This was disprovable because it did not restrict `x` and `y` to the positive quadrant. The informal statement is quite sloppy in this same sense (presumably because non-integral powers of negative reals are not defined). I have also proposed changing the implementation of "tangent to the curve" since a priori a line could intersect a degree `m` curve in up to `m` points so the naive set-counting definition is arguably too strong.
Configuration menu - View commit details
-
Copy full SHA for 6bc9d96 - Browse repository at this point
Copy the full SHA 6bc9d96View commit details -
This was disprovable because the hypothesis `apos : a > 0` means that `0 ≤ a n` for all `n` and there exists some `n` such that `0 < a n`. (So the sequence: 1, 0, 0, 0, 0, ... was admissible and provided a counter example to the statement.)
Configuration menu - View commit details
-
Copy full SHA for 7c68ba5 - Browse repository at this point
Copy the full SHA 7c68ba5View commit details -
This was previously "fixed" in c75c0b0 but unfortunately an error remained.
Configuration menu - View commit details
-
Copy full SHA for 12c5340 - Browse repository at this point
Copy the full SHA 12c5340View commit details -
This was disprovable because of a minor Mathlib footgun: namely the limsup of a real-valued function which is not bounded above is zero.
Configuration menu - View commit details
-
Copy full SHA for 5552a89 - Browse repository at this point
Copy the full SHA 5552a89View commit details -
This was disprovable because the zero function was excluded from the solution set. The fix is to replace `a > 0` with `a ≥ 0` in the solution. Other changes are just style. There is incidentally a sharper version of this question which requires establishing which solutions correspond to functions with finite / infinite domain. However this is not actually asked.
Configuration menu - View commit details
-
Copy full SHA for c109419 - Browse repository at this point
Copy the full SHA c109419View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.