Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few minor Lean misformalisations #243

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Nov 1, 2024

No description provided.

This was disprovable because the value `g 0` breaks the period-4
pattern. More precisely, the period 4 arises because powers of 2
mod 10 have period 4 (2, 4, 8, 6, 2, 4, 8, 6, ...). However this
starts at 2^1 and the inital value 2^0 = 1 breaks the pattern.

This was previously "fixed" in 295b586
but unfortunately an error remained.
This was disprovable because of an off-by-one error. Specifically, the
length of the list was the number of locations (including the initial
location) rather than the number of hops.

I have opted to rewrite the question in addition to fixing the error.
Copy link
Collaborator

@GeorgeTsoukalas GeorgeTsoukalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! As always, thanks for the contribution, Oliver!

@GeorgeTsoukalas GeorgeTsoukalas merged commit 9386906 into trishullab:main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants