Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor as_json in asyncio client #370

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Refactor as_json in asyncio client #370

merged 4 commits into from
Jul 28, 2023

Conversation

Tabrizian
Copy link
Member

@Tabrizian Tabrizian commented Jul 27, 2023 •
edited
Loading

Minor refactoring.

@Tabrizian Tabrizian requested a review from kthui July 28, 2023 17:29
rmccorm4
rmccorm4 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 🧠

@Tabrizian Tabrizian merged commit f7c45d3 into main Jul 28, 2023
3 checks passed
@Tabrizian Tabrizian deleted the imant-asjson branch July 28, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@kthui kthui kthui approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tabrizian @kthui @rmccorm4