Fix bug where null response were accidentally excluded from profile export #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
simple unit test to lock in this behavior and this is good to go |
matthewkotila
commented
Aug 10, 2023
matthewkotila
force-pushed
the
matthewkotila-null-response-bug
branch
from
41ebf06
to
f33b82d
Compare
matthewkotila
force-pushed
the
matthewkotila-null-response-bug
branch
from
f33b82d
to
c1902bb
Compare
matthewkotila
added a commit
that referenced
this pull request
Aug 11, 2023
…xport (#379) * Fix bug where null response were accidentally excluded from profile export * Fix bug * Address feedback
matthewkotila
added a commit
that referenced
this pull request
Aug 15, 2023
…xport (#379) * Fix bug where null response were accidentally excluded from profile export * Fix bug * Address feedback
matthewkotila
added a commit
that referenced
this pull request
Aug 15, 2023
* Update time stamp vector to hold a list of response times (#347) * WIP change to timestamp vector * Update testing to use new vector for end times * Fix lambda and tag todo with a ticket number * Fix iterator validation * Update PA async callback to only run with final response (#351) * Update PA async callback to only run with final response * Address feedback * Address feedback * Address feedback * Fix bug * Calculate response throughput metric (#356) * Calculate response throughput metric * Address feedback * Cleanup * add json schema for output file generation (#364) * Add json schema for output file and examples * Add newlines at end of files * Update json type to correct keyword * Update schema to fix hierarchy and address feedback * Add json file with known error for testing * Move example files to the docs directory * Remove some example json files * Update schema to use integer and remove uniqueness from timestamps * Add CLI option for profile export file (#369) * Add CLI option for profile export file * Address feedback * Store sequence ID in timestamps tuple object (#367) * Store sequence ID in timestamps tuple object * Fix bug and address feedback * Address feedback * Address feedback * Output response throughput metric to stdout and csv (#373) * Add missing --profile-export-file help description and cli docs description (#374) * create new json file output (#375) * Initial commit to gather all experiment data * Update response_timestamps variable name * Revert erase_indices deletion * Add reporter class to create json output * Add comments to public methods * Add file and stdout output * Copy valid request records into RawDataCollector * Plumb file path to reporter * Connect collector to reporter * Add json data to top level object * Add experiments value to document * Update json ints to uint64 and fix extry addition * Print seq id only when non zero * Moving schema to test repo * Only write file if specified * Address feedback * Address feedback --------- Co-authored-by: Matthew Kotila <[email protected]> Co-authored-by: tgerdes <[email protected]> * Fix bug where null response were accidentally excluded from profile export (#379) * Fix bug where null response were accidentally excluded from profile export * Fix bug * Address feedback * Add unit tests for ProfileDataCollector and ProfileDataExporter classes (#380) * Add initial mock class and test file for ProfileDataCollector * Mock FindExperiment method * Add test for FindExperiment and fix a bug in the function * Add tests for AddData and AddWindow in ProfileDataCollector * Add a skeleton unit test code for ProfileDataExporter * Mock ConvertToJson * Add subcase for ConvertToJson method * Add subcase for OutputToFile method * Add subcase for AddExperiment method * Split tests into multiple test cases * Set request rate as double in json * Address feedback --------- Co-authored-by: Elias Bermudez <[email protected]> Co-authored-by: tgerdes <[email protected]> Co-authored-by: Hyunjae Woo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null responses were accidentally not included in raw timestamps vector for each request. We actually want those in the profile export. This adds them in, but still excludes them from response throughput calculation.