Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cuda-python optional package dependency #423

Merged
merged 2 commits into from
Oct 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,16 @@ use,
$ pip install tritonclient[http]
```

There is another optional package namely *cuda*, that must be installed
in order to use cuda_shared_memory utilities. *all* specification will
install the *cuda* package by default but in other cases *cuda* needs to
be explicitly specified for installing client with cuda_shared_memory
support.

```
$ pip install tritonclient[http, cuda]
```

The components of the install packages are:

* http
Expand Down
1 change: 0 additions & 1 deletion src/python/library/requirements/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,5 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

cuda-python
numpy>=1.19.1
python-rapidjson>=0.9.1
27 changes: 27 additions & 0 deletions src/python/library/requirements/requirements_cuda.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Copyright 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
# * Neither the name of NVIDIA CORPORATION nor the names of its
# contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY
# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
# PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
# OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

cuda-python
1 change: 1 addition & 0 deletions src/python/library/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def req_file(filename, folder="requirements"):
extras_require = {
"grpc": req_file("requirements_grpc.txt"),
"http": req_file("requirements_http.txt"),
"cuda": req_file("requirements_cuda.txt"),
}

extras_require["all"] = list(chain(extras_require.values()))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
from cuda import cudart
except ModuleNotFoundError as error:
raise RuntimeError(
'CUDA shared memory utilities require Python package "cuda-python" to be installed'
"CUDA shared memory utilities require Python package 'cuda-python'"
"to be installed. Specify 'cuda' or 'all' while installing the tritonclient "
"package to include the support."
) from error

import base64
Expand Down
Loading