Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

feat: expose logs of detached instances via ganache instances logs command #4254

Draft
wants to merge 37 commits into
base: develop
Choose a base branch
from
Draft

feat: expose logs of detached instances via ganache instances logs command #4254

wants to merge 37 commits into from

Commits on Mar 8, 2023

  1. Basic implementation of logging to file

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    c7f86d3 View commit details
    Browse the repository at this point in the history

  2. Simplify logging

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    54b85c5 View commit details
    Browse the repository at this point in the history

  3. Simplify regex for inserting timestamps

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b0ca2e9 View commit details
    Browse the repository at this point in the history

  4. Remove --timestamps argument

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a397b6f View commit details
    Browse the repository at this point in the history

  5. Use a persistent filehandle instead of calling 'appendFile' each tile… 

    … a log is written
    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0f13a36 View commit details
    Browse the repository at this point in the history

  6. Introduce tests for logger, fail validation if path is not w 

    ritable
    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b206a42 View commit details
    Browse the repository at this point in the history

  7. Update tests to use per-test log files

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    d1ec4fe View commit details
    Browse the repository at this point in the history

  8. Resolve invalid path

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    feb57bd View commit details
    Browse the repository at this point in the history

  9. In windows, use reserved path 'c:\NUL' for invalid path

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0b8673f View commit details
    Browse the repository at this point in the history

  10. Revert changes and just await the rejection

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6d73be8 View commit details
    Browse the repository at this point in the history

  11. Let's do use the NUL workaround for windows

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    8b4ae04 View commit details
    Browse the repository at this point in the history

  12. Attempt to get tests to passing state

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    4b6159e View commit details
    Browse the repository at this point in the history

  13. Use current working directory as invalid file path

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    e2db28f View commit details
    Browse the repository at this point in the history

  14. Tidy up logging

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    d2db1a4 View commit details
    Browse the repository at this point in the history

  15. Create file when validating logging.file path is writable.

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    4e64fc7 View commit details
    Browse the repository at this point in the history

  16. Move logger into cli project, allow caller to close underlying fileha… 

    …ndle
    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    8423a65 View commit details
    Browse the repository at this point in the history

  17. Revert unrelated changes, fix flaky initialisation of logger

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    fcf39ed View commit details
    Browse the repository at this point in the history

  18. Fix error when no logging config exists

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    22ec214 View commit details
    Browse the repository at this point in the history

  19. Switch to use 'fs.openSync()' instead of 'fs.writeSync()' because win… 

    …dows won't if the content is empty :(
    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    37e1616 View commit details
    Browse the repository at this point in the history

  20. Work in progress. Move logger into @ganache/utils, resolve filehandle… 

    … within logging-options.
    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    44a7107 View commit details
    Browse the repository at this point in the history

  21. Improve tests, implementation, support for filecoin

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b02821d View commit details
    Browse the repository at this point in the history

  22. Finish tidying up implementation. Broke the console.log tests though … 

    …¯\_(ツ)_/¯
    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    4e7ddd6 View commit details
    Browse the repository at this point in the history

  23. Support setting both file and logger, refactor tangentially related test

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    f9aac47 View commit details
    Browse the repository at this point in the history

  24. tidy up implementation, fix tests, don't accept filehandle as logging… 

    ….file because then it's impossible for us to now whether we should close it
    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6cc6fb2 View commit details
    Browse the repository at this point in the history

  25. Update package-lock.json - adds reference to @ganache/utils

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    303330d View commit details
    Browse the repository at this point in the history

  26. Upgrade @ganache/utils

    @jeffsmale90
    jeffsmale90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7edf108 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Update reference to Logger type in tests

    @jeffsmale90
    jeffsmale90 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    ca8f581 View commit details
    Browse the repository at this point in the history

  2. Modify 'EPERM' test to support Windows (who does some freaky stuff wh… 

    …en a directory is opened for writing)
    @jeffsmale90
    jeffsmale90 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    04a0674 View commit details
    Browse the repository at this point in the history

  3. Pin @types/sinon

    @jeffsmale90
    jeffsmale90 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8352f82 View commit details
    Browse the repository at this point in the history

  4. Add test to ensure that resolved file descriptor is append only

    @jeffsmale90
    jeffsmale90 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    5a556d6 View commit details
    Browse the repository at this point in the history

  5. Fix failing tests

    @jeffsmale90
    jeffsmale90 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1ff9eb9 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/feat/logging' into feat/logging

    @jeffsmale90
    jeffsmale90 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d08ff26 View commit details
    Browse the repository at this point in the history

  7. Add test to ensure that provider.disconnect() closes the file descriptor

    @jeffsmale90
    jeffsmale90 committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b577089 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. implement 'ganache instances logs <name>' with support for --since, -… 

    …-until, and --follow
    @jeffsmale90
    jeffsmale90 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f4e7ad1 View commit details
    Browse the repository at this point in the history

  2. Fix issue where --follow fails with unhelpful error message, if the l… 

    …og file does not exist
    @jeffsmale90
    jeffsmale90 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    978aab1 View commit details
    Browse the repository at this point in the history

  3. Add logs-stream.fixture.log and improve related test, add tests for g… 

    …etLogsStream()
    @jeffsmale90
    jeffsmale90 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5b9a55b View commit details
    Browse the repository at this point in the history

  4. Improve help text for 'ganache instances logs'

    @jeffsmale90
    jeffsmale90 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    89ec342 View commit details
    Browse the repository at this point in the history