Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trustification-v0.7.2] TC-1757 Fix SPDX SBOM ingestion with multiple purls in externalRefs array #142

Merged
merged 4 commits into from
Oct 3, 2024
Merged

[trustification-v0.7.2] TC-1757 Fix SPDX SBOM ingestion with multiple purls in externalRefs array #142

merged 4 commits into from
Oct 3, 2024

Conversation

mrizzi
Copy link
Collaborator

@mrizzi mrizzi commented Oct 2, 2024 •
edited
Loading

Description of the PR

https://issues.redhat.com/browse/TC-1757

Backport

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

mrizzi and others added 4 commits October 2, 2024 12:48
@mrizzi
Fix SPDX SBOM ingestion with multiple purls in externalRefs array (gu…
c2a8063 
…acsec#2101)

Signed-off-by: mrizzi <[email protected]>
@mrizzi
TC-1757 e2e test
b811d19 
Signed-off-by: mrizzi <[email protected]>
@pxp928 @mrizzi
Parse CycloneDX Legal information (guacsec#1985)
f07f10a 
* update cdx parser to capture license information

Signed-off-by: pxp928 <[email protected]>

* complete update for cdx legal parser and update unit tests

Signed-off-by: pxp928 <[email protected]>

* make updates based on comments, add missing options for license for CDX and fix unit tests

Signed-off-by: pxp928 <[email protected]>

---------

Signed-off-by: pxp928 <[email protected]>
@mrizzi
CycloneDx: fix traverseComponents and license management
adb2e60 
Signed-off-by: mrizzi <[email protected]>
mrizzi
mrizzi commented Oct 3, 2024
View reviewed changes
Copy link
Collaborator Author

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically a backport of some PRs and the tests (both unit and e2e) are fine so I'm going to merge it.

@mrizzi mrizzi merged commit 896fe21 into trustification:trustification-v0.7.2 Oct 3, 2024
5 checks passed
@mrizzi mrizzi deleted the backport-TC-1757 branch October 3, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrizzi @pxp928