Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create versioned purls from OSV #897

Closed
wants to merge 1 commit into from

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Oct 7, 2024

Also see: #870

// extract PURLs

let mut purls = vec![];
purls.extend(translate::to_purl(package).map(Purl::from));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this some kind of hyper specific translate to purl ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think existing test has any assertions for checking versions for this specific fix might be worth adding, otherwise minor comments - LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants