Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getDecimals and its usage #149

Open
berndbohmeier opened this issue Nov 14, 2018 · 0 comments
Open

Refactor getDecimals and its usage #149

berndbohmeier opened this issue Nov 14, 2018 · 0 comments
Labels
type:refactor

Comments

@berndbohmeier
Copy link
Contributor

The function currently takes decimals and will just return them if given or query them if not given. This is not intuitive. We should refactor it so that it is the callers responsibility to do that.

This was also brought up by Thore as he was confused during the hackaton.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@berndbohmeier