Feature/get all trustlines of user #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we have been doing a lot redundant fetching just to get the respective decimals of a network. This introduces a caching mechanism through a closure, so that significantly lesser rest api calls are triggered without the need of the user to provide the decimals as options.
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
=========================================
- Coverage 63.25% 62.7% -0.55%
=========================================
Files 19 19
Lines 1173 1196 +23
Branches 220 225 +5
=========================================
+ Hits 742 750 +8
- Misses 372 384 +12
- Partials 59 62 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method for relay REST API
/users/<user_address>/trustlinesto return all trustlines of the requesting user.I also had to modify the
getDecimalsmethod for this. Because we are querying trustlines from multiple networks and these networks have different decimals, we somehow have to get these values viagetDecimals. Previously we were doing the respective call way too often and redundantly. I now added a caching mechanism to the method so that less decimals rest api calls are made. The refactoring is not quite in the context of #149 and more in the context of making the current usage more efficient.