Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eth-lightwallet dependency #191

Merged
merged 6 commits into from
Feb 12, 2019
Merged

Conversation

dohaki
Copy link
Contributor

@dohaki dohaki commented Feb 11, 2019

Closes #182

Removal of library and all artefacts related to eth-lightwallet.

Removal of library and all artefacts related to eth-lightwallet.

Remove unnecessary artefacts
Also includes some cleanup of config files.
@codecov-io
Copy link

codecov-io commented Feb 12, 2019

Codecov Report

Merging #191 into develop will decrease coverage by 4.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #191      +/-   ##
===========================================
- Coverage    69.28%   65.18%   -4.11%     
===========================================
  Files           16       15       -1     
  Lines          941      741     -200     
  Branches       140       82      -58     
===========================================
- Hits           652      483     -169     
+ Misses         257      241      -16     
+ Partials        32       17      -15
Flag Coverage Δ
#integration 38.15% <ø> (-1.05%) ⬇️
#unit 64.91% <ø> (-4.17%) ⬇️
Impacted Files Coverage Δ
src/TLNetwork.ts 97.61% <ø> (ø) ⬆️
src/User.ts 85.45% <0%> (-0.52%) ⬇️
src/CurrencyNetwork.ts 100% <0%> (ø) ⬆️
src/utils.ts 72.91% <0%> (+0.18%) ⬆️
src/Exchange.ts 25.19% <0%> (+0.95%) ⬆️
src/Trustline.ts 81.69% <0%> (+1.96%) ⬆️
src/Messaging.ts 44.44% <0%> (+4.44%) ⬆️
src/Event.ts 79.31% <0%> (+5.39%) ⬆️
src/wallets/EthersWallet.ts 66.12% <0%> (+6.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4abc6...3e02ac4. Read the comment docs.

Copy link
Contributor

@berndbohmeier berndbohmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dohaki dohaki merged commit d830113 into develop Feb 12, 2019
@dohaki dohaki deleted the refactor/remove-eth-lightwallet branch February 12, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants