Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some lmesreconcile methods #323

Conversation

tedhtchang
Copy link

@tedhtchang tedhtchang commented Oct 15, 2024

Refactors createPod other related methods to static functions because I need to create PodSet for Kueue integration using those functions

Copy link

openshift-ci bot commented Oct 15, 2024

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a trustyai-explainability member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tedhtchang tedhtchang force-pushed the lmes-reconsiler-refactor branch 2 times, most recently from 8f7d52c to cb4f1bb Compare October 16, 2024 04:12
@tedhtchang tedhtchang changed the title Refactor some lmesreconcile methods to static function Refactor some lmesreconcile methods Oct 16, 2024
@tedhtchang
Copy link
Author

/cc @yhwang

@openshift-ci openshift-ci bot requested a review from yhwang October 16, 2024 04:29
Copy link
Collaborator

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing typos and refactoring the serviceOptions as a singleton. good change

controllers/lmes/driver/driver_test.go Show resolved Hide resolved
controllers/lmes/lmevaljob_controller.go Outdated Show resolved Hide resolved
controllers/lmes/lmevaljob_controller.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yhwang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Oct 17, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:3b943ad81679794128955a960553e6f9f8327512

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:3b943ad81679794128955a960553e6f9f8327512

📦 LMES job image: quay.io/trustyai/ta-lmes-job:3b943ad81679794128955a960553e6f9f8327512

🗂️ CI manifests

@yhwang yhwang added lm-eval Issues related to LM-Eval ok-to-test labels Oct 18, 2024
@ruivieira ruivieira merged commit 61744ff into trustyai-explainability:dev/lm-eval Oct 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants