Skip to content

Commit

Permalink
update according to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
imrishabh18 committed Aug 12, 2024
1 parent 561f440 commit fba1358
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/lib/builder/net-builder/net-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export class NetBuilderClass implements NetBuilder {
is_digital_signal: this.props.is_digital_signal,
is_power: this.props.is_power,
is_ground: this.props.is_ground,
trace_width: this.props.trace_width,
},
]
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/builder/trace-hint-builder/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class TraceHintBuilderClass {
pcb_port_id: pcb_port.pcb_port_id,
pcb_component_id: pcb_port.pcb_component_id,
route,
trace_width: this.props.traceWidth ?? 0.1,
trace_width: this.props.traceWidth,

Check failure on line 109 in src/lib/builder/trace-hint-builder/index.ts

View workflow job for this annotation

GitHub Actions / prettier-check

Object literal may only specify known properties, and 'trace_width' does not exist in type '{ type: "pcb_trace_hint"; pcb_component_id: string; pcb_port_id: string; route: { x: number; y: number; via?: boolean | undefined; to_layer?: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6" | undefined; }[]; pcb_trace_hint_id: string; }'.

Check failure on line 109 in src/lib/builder/trace-hint-builder/index.ts

View workflow job for this annotation

GitHub Actions / prettier-check

Property 'traceWidth' does not exist on type 'Partial<{ for: string; order?: number | undefined; offset?: { x: string | number; y: string | number; via?: boolean | undefined; to_layer?: "top" | "bottom" | "inner1" | "inner2" | "inner3" | ... 4 more ... | undefined; } | undefined; offsets?: { ...; }[] | undefined; }>'.

Check failure on line 109 in src/lib/builder/trace-hint-builder/index.ts

View workflow job for this annotation

GitHub Actions / build-check

Object literal may only specify known properties, and 'trace_width' does not exist in type '{ type: "pcb_trace_hint"; pcb_component_id: string; pcb_port_id: string; route: { x: number; y: number; via?: boolean | undefined; to_layer?: "top" | "bottom" | "inner1" | "inner2" | "inner3" | "inner4" | "inner5" | "inner6" | undefined; }[]; pcb_trace_hint_id: string; }'.

Check failure on line 109 in src/lib/builder/trace-hint-builder/index.ts

View workflow job for this annotation

GitHub Actions / build-check

Property 'traceWidth' does not exist on type 'Partial<{ for: string; order?: number | undefined; offset?: { x: string | number; y: string | number; via?: boolean | undefined; to_layer?: "top" | "bottom" | "inner1" | "inner2" | "inner3" | ... 4 more ... | undefined; } | undefined; offsets?: { ...; }[] | undefined; }>'.
}

return [trace_hint]
Expand Down

0 comments on commit fba1358

Please sign in to comment.