Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added optional outline prop to board-builder #105

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

ShiboSoftwareDev
Copy link
Contributor

I ignored the gerber generator for now to work on the pcb-viewer first. The board will be drawn with the outline option if it has at least three elements in it, is it a good idea to default it to an empty array?

@ShiboSoftwareDev ShiboSoftwareDev requested review from seveibar and a team as code owners August 26, 2024 21:03
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, yea totally ok to skip the gerber generation

@seveibar
Copy link
Contributor

@ShiboSoftwareDev i think the installation is failing, maybe because of a bun lockfile issue

@ShiboSoftwareDev
Copy link
Contributor Author

I'm trying to fix it

@ShiboSoftwareDev
Copy link
Contributor Author

@seveibar I'm getting too many type errors, is it bacause it is using deprecated type definitions? It was using an older version of /props and /soup

@seveibar
Copy link
Contributor

@ShiboSoftwareDev yea i think you're getting hit with type errors that other people introduced, want to try to fix them? I think the changes are pretty minor, for route_thickness_mode it's supposed to default to "interpolated" but i think for some reason z....default("interpolated") needed to be z....default("interpolated").optional(), but we can patch it just by setting it explicitly in builder. Look like there are some other issues due to the upgrade that also are just small things like that :/

@ShiboSoftwareDev
Copy link
Contributor Author

@seveibar build checks succeeded but not format checks

@seveibar
Copy link
Contributor

yea the format check failure is related to tscircuit/plop#3

we need to update formatbot.yml to not run against forks.

The prettier check failing is legit though, are you able to run prettier against those files?

Note: we don't use prettier for other repos, but this repo is really really old lol

@seveibar
Copy link
Contributor

tried to fix the formatbot issue, hopefully this does it: 581f112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants