-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added optional outline prop to board-builder #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, yea totally ok to skip the gerber generation
@ShiboSoftwareDev i think the installation is failing, maybe because of a bun lockfile issue |
I'm trying to fix it |
@seveibar I'm getting too many type errors, is it bacause it is using deprecated type definitions? It was using an older version of /props and /soup |
@ShiboSoftwareDev yea i think you're getting hit with type errors that other people introduced, want to try to fix them? I think the changes are pretty minor, for |
@seveibar build checks succeeded but not format checks |
yea the format check failure is related to tscircuit/plop#3 we need to update formatbot.yml to not run against forks. The prettier check failing is legit though, are you able to run prettier against those files? Note: we don't use prettier for other repos, but this repo is really really old lol |
tried to fix the formatbot issue, hopefully this does it: 581f112 |
I ignored the gerber generator for now to work on the pcb-viewer first. The board will be drawn with the outline option if it has at least three elements in it, is it a good idea to default it to an empty array?