Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pcb snapshot added #90

Merged
merged 3 commits into from
Jul 30, 2024
Merged

feat: pcb snapshot added #90

merged 3 commits into from
Jul 30, 2024

Conversation

imrishabh18
Copy link
Member

@imrishabh18 imrishabh18 commented Jul 30, 2024 •
edited
Loading

seveibar
seveibar approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, would love to see it put in a test as an example too

@imrishabh18
Copy link
Member Author

Let me add and commit that.

@imrishabh18
Copy link
Member Author

True, the Github diff for snapshots looks neat!

@imrishabh18 imrishabh18 merged commit 214eda3 into main Jul 30, 2024
5 checks passed
@seveibar
Copy link
Contributor

@imrishabh18 looking at the dnapshot here, we might want to add a -pcb.snapshot.png or -sch.snapshot.png suffix so that prople could use both. Not a huge deal but might be nice

@seveibar seveibar mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imrishabh18 @seveibar @tscircuitbot