Fix: chip design #133
Merged
Fix: chip design #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
|
@seveibar The chip still needs more work regarding the port spacing for the pins. Will create an issue for that and work |
seveibar
reviewed
Oct 2, 2024
|
|
||
| project.render() | ||
|
|
||
| // expect(project).toMatchSchematicSnapshot(import.meta.path) |
There was a problem hiding this comment.
Curious why we dont keep the snapshot
There was a problem hiding this comment.
Cause it's a circle, the new circuit-to-svg needs to be published for this snapshot to work
There was a problem hiding this comment.
And for that to work, I need to publish this core 😆
seveibar
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.