Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce useRenderedCircuit and set up hook testing system #149

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Introduce useRenderedCircuit and set up hook testing system #149

merged 3 commits into from
Oct 8, 2024

Conversation

seveibar
Copy link
Contributor

@seveibar seveibar commented Oct 8, 2024

  • add useRenderedCircuit hook
  • create useRenderedCircuit and set up system that allows hooks to be tested
  • export useRenderedCircuit

@tscircuitbot
Copy link

Size Report

Bundle Size

  • Base branch size: 344K
  • PR branch size: 348K
  • Difference: +4

Install Size

  • Base branch size: 5.51mb
  • PR branch size: 5.52mb
  • Difference: +.01

Full Howfat Output (PR Branch)

@tscircuit/[email protected] (22 deps, 5.52mb, 637 files, ©undefined)
╭─────────────────────────────────────────┬──────────────┬──────────┬───────┬───────────┬──────────────┬───────────╮
│ Name                                    │ Dependencies │     Size │ Files │ Native    │ License      │ Deprec    │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @lume/[email protected]                        │              │  121.6kb │    31 │           │ BSD-3-Clause │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected]           │            2 │  858.3kb │    71 │           │ ISC          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected]   │              │ 241.24kb │    14 │           │              │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected]             │              │   20.4kb │    21 │           │              │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected]                 │              │ 446.02kb │    31 │           │ ISC          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/[email protected]             │            1 │ 273.54kb │    31 │           │ ISC          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected] │            1 │  54.54kb │    27 │           │              │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                     │            2 │   1.07mb │    66 │           │ ISC          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                            │              │  10.69kb │    11 │           │ MIT          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                   │              │  11.08kb │    17 │           │ MIT          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                 │            3 │   1.05mb │    43 │           │ MIT          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                            │            2 │ 331.04kb │    33 │           │ MIT          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                │              │ 263.15kb │    58 │           │              │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]            │              │ 430.45kb │    56 │           │ MIT          │           │
├─────────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ [email protected]                              │              │ 651.16kb │    50 │           │ MIT          │           │
╰─────────────────────────────────────────┴──────────────┴──────────┴───────┴───────────┴──────────────┴───────────╯

seveibar
seveibar commented Oct 8, 2024
View reviewed changes
lib/Circuit.ts
@@ -95,6 +95,10 @@ export class Circuit {
return this.getSoup()
}

toJson(): AnyCircuitElement[] {
return this.getSoup()
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ai kept thinking this method exists so it probably should exist 🤷 it's just an alias to getCircuitJson/getSoup

@imrishabh18 imrishabh18 merged commit e0d6195 into main Oct 8, 2024
5 checks passed
@seveibar seveibar deleted the use-rendered-circuit branch October 8, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrishabh18 imrishabh18 imrishabh18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seveibar @tscircuitbot @imrishabh18