Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tssop 3d component legs with footprints #47

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Fixed tssop 3d component legs with footprints #47

merged 9 commits into from
Oct 4, 2024

Conversation

anas-sarkez
Copy link
Member

Screenshot 2024-10-03 at 8 04 31 PM

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jscad-electronics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:21pm

@anas-sarkez anas-sarkez requested review from seveibar and removed request for seveibar October 3, 2024 18:32
seveibar
seveibar reviewed Oct 3, 2024
View reviewed changes
lib/Footprinter3d.tsx Outdated Show resolved Hide resolved
seveibar
seveibar requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at a high level this is good, but every component should have readable props, we don't want all the components to take fpJson: any

@seveibar
Copy link
Contributor

seveibar commented Oct 3, 2024

<Footprint3d /> is mostly responsible for mapping between fpJson and the components within this repo

@anas-sarkez anas-sarkez merged commit c7d8a83 into tscircuit:main Oct 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anas-sarkez @seveibar