Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sushi-bot: Add :x-logo: reaction to posts containing 'twitter' #843

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

hakatashi
Copy link
Member

@hakatashi hakatashi commented Aug 1, 2023

  • "twitter"を含む投稿に:x-logo:リアクションをつけるよう修正
  • ついでにslackMockのメソッドコールをjest.fn()でモックできるように

@hakatashi hakatashi self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 78.26% and project coverage change: +0.08% 🎉

Comparison is base (adaa6fa) 23.32% compared to head (d270b08) 23.41%.
Report is 1 commits behind head on master.

❗ Current head d270b08 differs from pull request most recent head 2d83201. Consider uploading reports for the commit 2d83201 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   23.32%   23.41%   +0.08%     
==========================================
  Files         173      173              
  Lines       15264    15284      +20     
  Branches     3489     3493       +4     
==========================================
+ Hits         3561     3578      +17     
- Misses      10296    10299       +3     
  Partials     1407     1407              
Files Changed Coverage Δ
lib/slackMock.js 90.00% <76.19%> (-6.16%) ⬇️
sushi-bot/index.ts 53.90% <100.00%> (+0.38%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hakatashi hakatashi changed the title sushi-bot: Add reaction to add x-logo on 'twitter' sushi-bot: Add :x-logo: reaction to posts containing 'twitter' Aug 1, 2023
Copy link
Member

@cookie-s cookie-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no_goodとshaved_iceはいれなくて大丈夫ですか

@hakatashi
Copy link
Member Author

shaved_iceを入れる理由は、ないだろ

no_goodは入れてもいいかもだけど、まあ、あんまりリアクション多いと鬱陶しいので

@hakatashi hakatashi merged commit a2bf0e6 into master Aug 1, 2023
5 checks passed
@hakatashi hakatashi deleted the sushi-bot-x-logo branch August 1, 2023 13:34
@cookie-s
Copy link
Member

cookie-s commented Aug 1, 2023

近年、とあるサービスは、外部の類似サービスへの誘導リンクを張ることを禁じるポリシーを発表しました。ポリシー違反を行えば当該アカウントが止められることも考えられます。間もなくそのポリシーへのアクセスはできなくなったため、今そのポリシーの有効性については分かりません。ただし、そのサービスがリブランディングのために名前を変えた場合、元のサービス名は類似サービスの名前としての扱いをうける可能性もあるのではないでしょうか。

@hakatashi
Copy link
Member Author

サイコパスすぎる

@cookie-s
Copy link
Member

cookie-s commented Aug 2, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants