市章当てクイズで都道府県を指定できるように #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakatashi
approved these changes
Oct 20, 2024
city-symbol/index.ts
Outdated
| placeImage: 'https://raw.githubusercontent.com/hakatashi/icon/master/images/icon_480px.png', | ||
| ruby: 'はかたし', | ||
| }; | ||
| const getRandomCitySymbol = async (prefSet: Set<PrefectureKanji> = new Set(Object.keys(prefectures) as PrefectureKanji[]), allowEasterEgg: boolean = true): Promise<City> => { |
There was a problem hiding this comment.
[MAY]
allowEasterEggいらないきがする (prefsetが指定されていればfalseでよさそう)
There was a problem hiding this comment.
[MAY] 変換めんどくさいのでまあArrayでよさそう?
There was a problem hiding this comment.
allowEasterEgg
なんかもうちょい別の（イースターエッグを消したい）状況が出たときのために引数入れといてもいいかな～と雑に思っています
Array
ま～やっぱそうかなあ（意味的には Set であってほしいが、回りくどいな～とは思っていた）
Co-authored-by: Koki Takahashi <[email protected]>
settyan117
force-pushed
the
dev/settyan117/city-symbol-specify-pref
branch
from
13c90ee
to
ff1b21e
Compare
hakatashi
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
した
・都道府県を指定したときは実績は解除しない