Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal]Add basic prettier setup #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Proposal]Add basic prettier setup #170

wants to merge 1 commit into from

Conversation

Mindaugas-Jacionis
Copy link

I would like to suggest using prettier to enforce code consistency across the project and help out anyone who wants to contribute 🙂

tshaddix
tshaddix requested changes Feb 17, 2019
View reviewed changes
Copy link
Owner

@tshaddix tshaddix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for doing this! Definitely needed. I think we can remove the references to style files out of the ignore

.prettierignore
*.*
!*.js
!*.css
!*.scss
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to ignore .css and .scss files? I'm not aware of any in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshaddix tshaddix tshaddix requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mindaugas-Jacionis @tshaddix