Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move-in ready #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Move-in ready #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8d6ba3
Added "Read more" link and summary intead of full content.
deberon Mar 5, 2017
ef630e2
Put the site tagline in the sidebar.
deberon Mar 5, 2017
caa88cb
Added vim files to .gitignore.
deberon Mar 5, 2017
52566eb
Removed Github links from sidebar.
deberon Mar 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
jekyll/**
public/**
hugout/**
*.swp
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I would prefer to exclude editor-specific cruft from gitignore files. A vim user can fix this for their own system with a user-wide gitignore or .git/info/excludes.

3 changes: 2 additions & 1 deletion layouts/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
<div class="post">
<h1 class="post-title"><a href="{{ .Permalink }}">{{ .Title }}</a></h1>
<span class="post-date">{{ .Date.Format .Site.Params.DateForm }}</span>
{{ .Content }}
<p>{{ .Summary }}</p>
<p><a href="{{ .Permalink }}" >Read more</a></p>
Copy link
Owner

@tummychow tummychow Mar 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in the hugo documentation for this feature that there's a Truncated flag to indicate if the read-more link is necessary or not. Could you elide the link if Truncated is false? Implementation would be similar to the example given in the docs.

edit: in fact, it might make more sense to have something like this:

{{ if .Truncated }}
  <p>{{ .Summary }}</p>
  <p><a href="{{ .Permalink }}" >Read more</a></p>
{{ else }}
  {{ .Content }}
{{ end }}

so if the content is short enough that it doesn't need a summary, then it's reproduced verbatim without stripping html tags.

</div>
{{ end }}
</div>
Expand Down
5 changes: 1 addition & 4 deletions layouts/partials/sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<!-- Toggleable sidebar -->
<div class="sidebar" id="sidebar">
<div class="sidebar-item">
<p>A reserved <a href="http://jekyllrb.com" target="_blank">Jekyll</a> theme that places the utmost gravity on content with a hidden drawer. Made by <a href="https://twitter.com/mdo" target="_blank">@mdo</a>.</p>
<p>{{ .Site.Params.Tagline }}</p>
</div>

<nav class="sidebar-nav">
Expand All @@ -19,9 +19,6 @@
{{ end }}
{{ end }}

<a class="sidebar-nav-item" href="{{ .Site.Params.Github.Url }}/archive/{{ .Site.Params.Github.Head }}.zip">Download</a>
<a class="sidebar-nav-item" href="{{ .Site.Params.Github.Url }}">GitHub project</a>
<span class="sidebar-nav-item">Currently on {{ .Site.Params.Github.Head }}</span>
</nav>

<div class="sidebar-item">
Expand Down