Optimize local database access #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
force-pushed
the
optimize-local
branch
3 times, most recently
from
ca0fbd3
to
a18174c
Compare
We currently open a new SQLite connection for every SQL statemenet we execute. This is wasteful with better-sqlite3, but even more wasteful with libsql, which sets up remote connectivity in case it needs to do write delegation. To fix the issue, let's reuse the connection in a client, which reduces local query latency by up to almost 10x: Before: ``` penberg@vonneumann remote-based-sync % bun run index.ts The keycard for user Glauber is valid. Query took 3ms The keycard for user Glauber is valid. Query took 2ms The keycard for user Glauber is valid. Query took 965us The keycard for user Glauber is valid. Query took 815us The keycard for user Glauber is valid. Query took 726us The keycard for user Glauber is valid. Query took 740us The keycard for user Glauber is valid. Query took 720us The keycard for user Glauber is valid. Query took 690us The keycard for user Glauber is valid. Query took 682us The keycard for user Glauber is valid. Query took 701us ``` After: penberg@vonneumann remote-based-sync % bun run index.ts ``` The keycard for user Glauber is valid. Query took 1ms The keycard for user Glauber is valid. Query took 644us The keycard for user Glauber is valid. Query took 296us The keycard for user Glauber is valid. Query took 197us The keycard for user Glauber is valid. Query took 177us The keycard for user Glauber is valid. Query took 175us The keycard for user Glauber is valid. Query took 192us The keycard for user Glauber is valid. Query took 150us The keycard for user Glauber is valid. Query took 135us The keycard for user Glauber is valid. Query took 148us ```
penberg
force-pushed
the
optimize-local
branch
from
a18174c
to
a2a121a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently open a new SQLite connection for every SQL statemenet we
execute. This is wasteful with better-sqlite3, but even more wasteful
with libsql, which sets up remote connectivity in case it needs to do
write delegation.
To fix the issue, let's reuse the connection in a client, which reduces
local query latency by up to almost 10x:
Before:
After:
penberg@vonneumann remote-based-sync % bun run index.ts