Use Hrana 3 when available #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to
@libsql/hrana-clientversion 0.5 to transparently use Hrana 3 if the server supports it. This allows us to fix a hole in thetransaction()andbatch()APIs: previously, if the transaction was rolled back usingROLLBACKor using theOR ROLLBACKconflict resolution strategy, the following statements would be executed outside of a transaction. With Hrana 3, we can usehrana.BatchCond.isAutocommit()to fix this.The Hrana client will also internally use cursors (streaming) to implement batches. This means that the server does not have load the full result set into memory before sending it, which reduces memory pressure. However, the client API is unchanged, so the client will still keep all results in memory.