accept K parameter as float if there is no loss in the precision after rounding to the integer #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r rounding to the integer - it cah be hard in some cliens (JS for example) to distinguish between INTEGERs and FLOATs - so we always bind FLOATs instead - this create unnecessary error: "vector index(search): third parameter (k) must be a non-negative integer"
LucioFranco
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It can be hard in some clients (JS for example, see) to distinguish between INTEGERs and FLOATs - so we always bind FLOATs instead (
This create unnecessary error:
vector index(search): third parameter (k) must be a non-negative integerThis PR fixes vector search and make it tolerant to the FLOAT parameter if there is no precision loss (so, the provided FLOAT value is actually INTEGER). In case of precision loss (for example, user provided value
2.5for theKparameter) the error message will look like this:vector index(search): third parameter (k) must be an integer, but float value were provided