upload to Google Play with GitHub Actions, remove Bitrise #4682
Conversation
|
Looks good so far! |
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - '*' | ||
| pull_request: |
There was a problem hiding this comment.
| pull_request: | |
| push: | |
| branches: | |
| - develop | |
| pull_request: |
There was a problem hiding this comment.
Why? The action already that runs on develop already includes this action, this would run it twice?
There was a problem hiding this comment.
You mean .github/workflows/populate-gradle-build-cache.yml? It has been deleted in this PR.
There was a problem hiding this comment.
No, I meant the deploy-test has uses: ./.github/workflows/check-and-build.yml and runs on develop, but it actually doesn't 😅
I'll fix that, thanks
| - name: Copy CI gradle.properties | ||
| run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties | ||
|
|
||
| - name: Gradle Build Action | ||
| uses: gradle/gradle-build-action@v3 | ||
| uses: gradle/actions/setup-gradle@v4 | ||
| with: | ||
| cache-read-only: ${{ github.ref != 'refs/heads/main' && github.ref != 'refs/heads/develop' }} |
There was a problem hiding this comment.
| cache-read-only: ${{ github.ref != 'refs/heads/main' && github.ref != 'refs/heads/develop' }} |
| - uses: r0adkll/sign-android-release@f30bdd30588842ac76044ecdbd4b6d0e3e813478 | ||
| name: Sign Tusky Blue aab | ||
| id: sign_aab | ||
| with: | ||
| releaseDirectory: app/build/outputs/bundle/blueRelease | ||
| signingKeyBase64: ${{ secrets.KEYSTORE }} | ||
| alias: ${{ secrets.KEY_ALIAS }} | ||
| keyStorePassword: ${{ secrets.KEYSTORE_PASSWORD }} | ||
| keyPassword: ${{ secrets.KEY_PASSWORD }} |
There was a problem hiding this comment.
There was a problem hiding this comment.
I'd prefer it if we don't touch the build.gradle files
There was a problem hiding this comment.
I'll address that in a separated PR.
|
Yeah, neither am I, I fully expect some kind of mistake but we will only know when we try it out. |
Re: #4682 (comment) Ok that was quick. According to the error message, that should fix the problem. https://github.com/tuskyapp/Tusky/actions/runs/11256946411/job/31300028953
closes #4236
I hope I did everything correctly, we will find out after this is merged.
I am setting up the environment variables containing the keys so they are only available to actions that need them.
This should be easier to maintain, GitHub seems to be faster then Bitrise, and we no longer have two checks on every pull request.