Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rakefile for sass-embedded (dart-sass) #268

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Update Rakefile for sass-embedded (dart-sass) #268

merged 2 commits into from
Jan 11, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Jan 1, 2024 •
edited
Loading

The actual sass engine used by dartsass-sprockets is sass-embedded.

This PR makes the following changes to Rakefile:

  • Use the new API directly instead of using the SassC API shim.
  • Provide filename option to SassC, and remove load_path option, because imports can be resolved relative to provided filename.

@ntkme
Copy link
Contributor Author

ntkme commented Jan 9, 2024

@glebm dartsass-ruby has been archived and is no longer used by latest version of dartsass-sprockets. Would you mind take a look?

@glebm
Copy link
Member

glebm commented Jan 11, 2024

Looks like this breaks CI on ruby 2.5.

@glebm glebm merged commit 90467de into twbs:main Jan 11, 2024
26 checks passed
@glebm
Copy link
Member

glebm commented Jan 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntkme @glebm