Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rails test #287

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix rails test #287

merged 1 commit into from
Sep 2, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Sep 2, 2024

This PR fixes the following rails test failure: https://github.com/twbs/bootstrap-rubygem/actions/runs/10660744940

Apparently something has changed recently that now the Chrome running test will try request /favicon.ico, and that causes all the tests to fail:

Minitest::UnexpectedError:         ActionController::RoutingError: No route matches [GET] "/favicon.ico"

This PR simply adds an empty favicon.ico in order to avoid this test failure.

@glebm glebm merged commit 1e6b6b2 into twbs:main Sep 2, 2024
26 checks passed
@glebm
Copy link
Member

glebm commented Sep 2, 2024

Thanks!

@ntkme ntkme deleted the fix-test branch September 2, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants