Bug Fix: created new div and p tag styles and wrap it on the workspace member as container #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request addresses text overflow issues in workspace member displays by introducing new styled components for text truncation with ellipsis.
- Added
StyledEllipsisParagraphinSettingsDataModelObjectSummary.tsxto truncate text exceeding 80px width - Removed
StyledObjectNameand object icon display fromSettingsDataModelObjectSummary.tsx - Modified
SettingsDataModelFieldSettingsFormCard.tsxandSettingsDataModelFieldRelationSettingsFormCard.tsxto incorporate new text styling - Deleted
.env.examplefiles from bothtwenty-frontandtwenty-serverpackages, potentially impacting project setup - Inconsistency between PR description and actual changes in
SettingsDataModelFieldRelationSettingsFormCard.tsxneeds addressing
5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
...dules/settings/data-model/fields/forms/components/SettingsDataModelFieldSettingsFormCard.tsx
Outdated
Show resolved
Hide resolved
...ta-model/fields/forms/relation/components/SettingsDataModelFieldRelationSettingsFormCard.tsx
Outdated
Show resolved
Hide resolved
...ages/twenty-front/src/modules/settings/data-model/objects/SettingsDataModelObjectSummary.tsx
Show resolved
Hide resolved
ehconitin
reviewed
Oct 10, 2024
...dules/settings/data-model/fields/forms/components/SettingsDataModelFieldSettingsFormCard.tsx
Outdated
Show resolved
Hide resolved
...ta-model/fields/forms/relation/components/SettingsDataModelFieldRelationSettingsFormCard.tsx
Outdated
Show resolved
Hide resolved
|
@SyedHamzaHussain000 still missing the twenty-server .env.example :) |
|
@charlesBochet Sorry about that. I fixed that and push the new commit please check Thankyou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Hope you are doing well.I created a special style for the text to make sure it stays in one line and wont exceed the width if the text width will be more then 80px it will ecplise and set ... at the end of the text.
I created these 2 styles variables and wrap my text in these styles
StyledObjectSummary
StyledEllipsisParagraph
Fixes #7574
#Screens Shots
