Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: node18+ supported and lodash vulnerability fixed #592

Merged
merged 6 commits into from
May 21, 2024
Merged

chore: node18+ supported and lodash vulnerability fixed #592

merged 6 commits into from
May 21, 2024

Conversation

tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented May 10, 2024 •
edited
Loading

Fixes

Dropped support for node 14 and 16. Removing vulnerable version of lodash and removed transitive dependency

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

sbansla
sbansla previously approved these changes May 16, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tiwarishubham635 tiwarishubham635 changed the title chore: upgrading lodash to 4.17.21 and removing lodash.template chore: node18+ supported and lodash vulnerability fixed May 20, 2024
@tiwarishubham635 tiwarishubham635 merged commit cdb75ff into main May 21, 2024
10 checks passed
@tiwarishubham635 tiwarishubham635 deleted the lodash_vul branch May 21, 2024 05:42
twilio-dx pushed a commit that referenced this pull request May 24, 2024
@semantic-release-bot
chore(release): set package.json to 5.20.0 [skip ci]
d061465 
## [5.20.0](5.19.4...5.20.0) (2024-05-24)

### Library - Chores

* bump cli-core version ([#594](#594)) ([ddb58fc](ddb58fc))
* node18+ supported and lodash vulnerability fixed ([#592](#592)) ([cdb75ff](cdb75ff))
@tiwarishubham635 tiwarishubham635 mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kridai kridai kridai approved these changes

@sbansla sbansla sbansla approved these changes

@shrutiburman shrutiburman Awaiting requested review from shrutiburman

@AsabuHere AsabuHere Awaiting requested review from AsabuHere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiwarishubham635 @kridai @sbansla