-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VBLOCKS-3535] feat: proof of concept appium testing #438
base: feature/appium
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example I can look at for how the other team is using appium?
- So we would need to create the UI for every test we make?
- Since this is just 1 test case and has ~100 lines, each test case would be around the same length?
- One concern I see is that it looks tedious to manually set status for each test.
} | ||
|
||
await new Promise((resolve) => { | ||
setTimeout(resolve, 5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the manual wait time still necessary? appium doesn't have a way to .wait
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So appium does have a way to wait, but the way I set up the test such that each test is it's own UI and each hook is it's own test run time means that appium isn't in control here. At this point, it's app code, and the appium wait is more similar to how jest waits for tests to finish since appium is the test runner.
Yeah those concerns are very valid. I have a few ideas on how to cut down on boilerplate, but in the end it will be pretty lengthy for each test compared to the type of testing we're used to. If you compare to how the current tests work, with a "full blown" test app and just doing e2e testing on that, it's not going to be too different in terms of total length. |
Submission Checklist
CHANGELOG.md
to reflect any feature, bug fixes, or known issues made in the source codeFiles changed
tab prior to submitting the pull request for review to ensure proper usage of the style guideDescription
This PR adds a proof of concept test to the repo test app using appium.
Breakdown
Validation
Additional Notes
N/A