Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude debug build for macos #480

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

brayniac
Copy link
Contributor

@brayniac brayniac commented Oct 19, 2022

macos builds continue to be flakey in ci for debug builds. In order to make ci less flakey, this change adds an exclude for debug build under macos

macos builds continue to be flakey in ci for debug builds. In order
to make ci less flakey, this change splits linux and macos builds
and drops debug mode for macos builds.
@brayniac brayniac changed the title ci: split macos from linux builds ci: exclude debug build for macos Oct 19, 2022
Copy link
Contributor

@swlynch99 swlynch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself LGTM but the macos-release job is failing for what looks like a similar reason as the debug one.

@brayniac
Copy link
Contributor Author

The change itself LGTM but the macos-release job is failing for what looks like a similar reason as the debug one.

Yeah - well, at least we can rule out debug mode as part of it. I'll open a separate PR to start troubleshooting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants