Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to bzlmod, bump deps #402

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Conversation

agluszak
Copy link

What is the goal of this PR?

Bzlmod migration.

What are the changes implemented in this PR?

All rulesets used have been bumped, WORKSPACE file has been removed.
Closes #370. The next step would be to publish this repo to BCR

@typedb-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@mgosk
Copy link

mgosk commented Apr 4, 2024

+1 for merging this PR into master branch. I am already using this change from PR branch.

@alexjpwalker
Copy link
Member

Thanks for the submission. I'm all for Bzlmod migration and this is something we have previously looked into. However it may take some time for the entire org to be ready for migration (and the upgrade to Bazel 7) as we have at least 20 repositories that would need to be migrated. Please continue to depend on your fork for now and we'll revisit this further down the line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bzlmod support
4 participants