Migrate ReasoningIT to BDD #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjpwalker
changed the title
added 20 commits
July 21, 2020 18:46
Its tests are all implemented in other files.
flyingsilverfin
approved these changes
Jul 27, 2020
jmsfltchr
approved these changes
Jul 28, 2020
alexjpwalker
pushed a commit
to typedb/typedb
that referenced
this pull request
Jul 28, 2020
## What is the goal of this PR? To identify and de-duplicate integration tests that test the fundamentals of Reasoner, categorise them appropriately and migrate them to BDD scenarios. This PR will focus exclusively on ReasoningIT. This PR forms part of the work towards #5721 ## What are the changes implemented in this PR? Migrate tests away from IT files as they get moved to BDD in typedb/typedb-behaviour#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
To identify and de-duplicate integration tests that test the fundamentals of Reasoner, categorise them appropriately and migrate them to BDD scenarios.
This PR focuses on ReasoningIT in grakn.
This PR forms part of the work towards typedb/typedb#5721
What are the changes implemented in this PR?
Added tests that were migrated from the relevant IT files in grakn. Also moved some tests around, so that everything is in the right place.