Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cucumber BDD dependencies for C++ #572

Draft
wants to merge 4 commits into
base: development
Choose a base branch
from
+7 −7
Draft

Update cucumber BDD dependencies for C++ #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a552fe9
WIP: Once each gherkin & messages release, we can move the dependenci…
krishnangovindraj Jan 19, 2024
c325e2c
Bump dependencies to my fork for CI
krishnangovindraj Mar 27, 2024
0f22858
Point dependencies to merged vaticle/dependencies commit
krishnangovindraj Apr 3, 2024
6daebc3
Bump dependencies again to include json
krishnangovindraj Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cpp/test/cucumber/lib/runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
#include <sstream>
#include <string>

#include <gherkin/parser.hpp>
#include <gherkin/pickle_compiler.hpp>
#include <gherkin/utils.hpp>
#include <cucumber/gherkin/parser.hpp>
#include <cucumber/gherkin/pickle_compiler.hpp>
#include <cucumber/gherkin/utils.hpp>

#include "cucumber_bdd/runner.hpp"

Expand All @@ -44,10 +44,10 @@ std::string type_name();

void TestRunnerBase::loadFeature(const std::string& path) {
// std::regex testFilter = std::regex(::testing::GTEST_FLAG(filter), std::regex::extended);
std::string featureContents = gherkin::slurp(path);
gherkin::parser parser;
std::string featureContents = cucumber::gherkin::slurp(path);
cucumber::gherkin::parser parser;
cucumber::messages::gherkin_document doc = parser.parse(path, featureContents);
gherkin::pickle_compiler compiler;
cucumber::gherkin::pickle_compiler compiler;

if (doc.feature.has_value()) {
for (cucumber::messages::pickle scenario : compiler.compile(doc, path)) {
Expand Down
2 changes: 1 addition & 1 deletion dependencies/vaticle/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def vaticle_dependencies():
git_repository(
name = "vaticle_dependencies",
remote = "https://github.com/vaticle/dependencies",
commit = "f3ab3f76e2f82f1f8b12464d95948b637f655f5d", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
commit = "a0a07919a96c56c565b9a4b5633c47d3d60c6ac3", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
)

def vaticle_typeql():
Expand Down