Rework interfaces and implementations #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milessabin
added
bug
+ Object type fields mapped at the interface level and interface type fields which are implemented or overridden at the object type level are now explicitly represented internally. This allows both more efficient lookup of inherited field mappings and correct lookup of overriden field mappings. + Field mapping lookup is now more effectively indexed TypeMappings. This might give a noticeable performance improvement for ValueMapping. Now that this indexing in centralised in TypeMappings, the per-ObjectMapping field indices have been removed. If this proves problematic for applications it could be reinstated. + Schema validation now enforces the uniqueness of interfaces in implements clauses. + Schema validation now enforces that object and interface types must directly implement all transitively implemented interfaces. The allInterfaces method on InterfaceType has been deprecated because with the preceeding validation change it would equivalent to interfaces. + The Mapping specific logic of mkCursorForField has been extracted to mkCursorForMappedField allowing simpler mapping-specific implementations. + Previously introspection did not report interfaces implemented by interfaces. + Added Schema#implementations which returns the implementing Object types of an interface. + The unsafe TypeMappings constructor has been deprecated and renamed to unchecked. + TypeMappings#unsafe has been renamed to unchecked and hidden + The implementations of hasField, nullableHasField, hasPath and hasListPath in Cursor had incorrect semantics and appear to be unused, so rather than fix them, they have been removed. + Various tests have been updated to conform to the newly implemented validation rules and changes to field mapping lookup.
milessabin
force-pushed
the
topic/interface-rework
branch
from
50983f6
to
f195926
Compare
tpolecat
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeMappings. This might give a noticeable performance improvement forValueMapping. Now that this indexing in centralised inTypeMappings, the per-ObjectMappingfield indices have been removed. If this proves problematic for applications it could be reinstated.implementsclauses.allInterfacesmethod onInterfaceTypehas been deprecated because with the preceding validation change it is equivalent tointerfaces.Mapping-specific logic ofmkCursorForFieldhas been extracted tomkCursorForMappedFieldallowing simpler mapping-specific implementations.Schema#implementationswhich returns the implementing object types of an interface.unsafeTypeMappingsconstructor has been deprecated and renamed tounchecked.TypeMappings#unsafehas been renamed touncheckedand hiddenhasField,nullableHasField,hasPathandhasListPathinCursorhad incorrect semantics and appear to be unused, so rather than fix them, they have been removed.