make effect elaborator respect predicated mappings #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm this is causing some failures on our end, looks like. Closing for now. |
|
Ok the failure was unrelated to this. It also may be the cause of our problems with #634 so I'll circle back to that. |
|
@milessabin we're blocked on this issue so it would be nice to get a release out if it looks ok to you. |
|
Yeah, that looks like it was an oversight part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
EffectElaboratorto accept an arbitrary function that maps context+field to effect handler, allowing users to delegate totypeMappings.fieldMapping(which understands predicated mappings).