Fix HTTP client handling and configuration in Typesense PHP client #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What is this?
This PR fixes an issue with HTTP client handling in the Typesense PHP client library where
PSR-18 compatible clients were being unnecessarily wrapped and recreated on every request.
This improves performance and provides better compatibility with different HTTP client
implementations.
Changes
Code Changes:
In
src/Lib/Configuration.php
:HttpMethodsClient
instances without wrappingIn
tests/Feature/HttpClientsTest.php
(New):Documentation Updates:
.gitignore
:.env
andtypesense-data
to ignore local development filesContext
This fixes issue #77 reported by @ragusa87 where passing a PSR-18 client instance
to the configuration would fail with:
The fix ensures proper handling of different client types while maintaining backward
compatibility and improving performance by avoiding unnecessary client wrapping and
recreation.
PR Checklist