-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache the installation to avoid redownloading & switch to Node.js #12
Conversation
Thank you very much for contributing. I checked out the discussion you posted too, and I'll give 'em both a good look-see over the weekend. To tell you the truth, I originally wrote this action just for my own use. I was thinking about making this project in Node.js before, but I had trouble with downloading releases back then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Taking advantage of my free time today, I have thoroughly reviewed your contributions.
Additionally, I am considering adding you as a collaborator (and even including you in the license if you wish), what do you think?
Co-authored-by: yusancky <[email protected]>
Sounds great! 👍 I also want to bring up: I think that this setup-typst GitHub Action would be a great project to put under the @typst-community organization. IMO it would be best to coincide that with the release of v3 of this action. Do you think that this would be a good move? Sidenote: GitHub will redirect Actions to their new name no problem |
So I just need to do this to transfer to @typst-community then? |
Pretty much!
That's the gist of it. I did ☝ with https://github.com/typst-community/typst.js and it worked out pretty well so far. 🤷♂️ Then once you're ready (after transferring or not transferring if you decide that) create a new GitHub release via the GitHub UI with a tag of |
Hey 👋, Came here to confirm on the request of @jcbhmr, @yusancky, do you want to drop setup-typst in the typst-community org? I'm questioning if you, personally feel like you'll benefit in any way in doing so if the organization itself cannot offer anything right now, as it is just an aggregrate of community projects. However, it does have goals, close to that of other *-community organizations. Take @coq-community for one, for reasons why you could want to have a repository on *-community organization (from github:coq-community/manifesto):
If you have no interest in doing so, it's completely fine. If you do, then I'll proceed by extending an invite. context@jcbhmr's reach out, was if my understanding is correct, purely with the thought that such project, a |
@huwaireb Sure, I'd be happy with that! |
👋 Hello @yusancky!
I'm opening this PR because this seems to be the premiere Typst-installer GitHub Action. However, it doesn't cache the installation which is a big downside. Then after adding caching support I got carried away and did a bunch more stuff lol. 😅
This PR would:
typst --version
andtypst compile test.typ
to make sure it works. https://github.com/jcbhmr/setup-typst/actionsnpm install && node main.js
, it just doesnode main.js
. Therefore, you need to bundle all your dependencies.dist/main.js
bundled Vite artifact on each new release.