Rewrite readme and fix workflows #25811
Open
+137
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
permanentdaylightt
changed the title
MasterKia
reviewed
Oct 30, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| ### Notes | ||
|
|
||
| [Add here the result of whatever investigation work you have done: please investigate the issues you report -- this prevents burdening other volunteers. This is especially true for issues arising from settings which are very different from default ones.] | ||
| [Add here the result of whatever investigation work you have done: please investigate the issues you report—this prevents burdening other volunteers. This is especially true for issues arising from settings which are very different from default ones.] |
There was a problem hiding this comment.
There should be a space for better readability.
There was a problem hiding this comment.
ty for noticing, my bad
MasterKia
reviewed
Oct 30, 2024
|
By the way, maybe would be good to include also changes from this one as well, as it adds missing things that are handled in uAssets but were not ever mentioned so far (I would also add: redirections): |
thanks for noticing btw @garry-ut99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed workflows so theyre getting run as described