Merge pull request #588 from ua-parser/lbarthon/chromecast-fix

fix(device): ensure chromecast parsing doesn't return null
ua-parser · Jun 3, 2024 · df56280 · df56280
2 parents ae4c16d + 3421cb1
commit df56280
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/regexes.yaml b/regexes.yaml
@@ -2513,7 +2513,7 @@ device_parsers:
   - regex: 'CrKey/'
     brand_replacement: 'Google'
     device_replacement: 'Chromecast'
-    model_replacement: null
+    model_replacement: 'Chromecast'
 
   #########
   # Cloudfone

diff --git a/tests/test_device.yaml b/tests/test_device.yaml
@@ -7763,7 +7763,7 @@ test_cases:
   - user_agent_string: 'Mozilla/5.0 (X11; Linux armv7l) CrKey/1'
     family: 'Chromecast'
     brand: 'Google'
-    model: null
+    model: 'Chromecast'
 
   - user_agent_string: 'Mozilla/5.0 (Linux; U; Android 2.3.5; En-gb; Cloudfone_Excite320e Build/GRJ90) AppleWebKit/533.1 (KHTML, Like Gecko) Version/4.0 Mobile Safari/533.1'
     family: 'Cloudfone Excite 320e'