Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing and extra patch_minor in ua tests #579

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix missing and extra patch_minor in ua tests #579

merged 1 commit into from
Apr 23, 2024
+23 −3

Commits on Apr 20, 2024

  1. fix missing and extra patch_minor in ua tests 

    `patch_minor` was added to regexes and some test_ua entries in ua-parser#322.

Neither spec nor reference implementation were ever updated for it, so
many regexes were merged (?) with a capture for `patch_minor` but
without correctly asserting it, and a pair of cases specify a
`patch_minor` which is not captured:

- the facebook regex[^1] only has 4 capturing groups
- same for the AWS regex[^2]

[^1]: https://github.com/ua-parser/uap-core/blob/959e106754828ae557b0dbcfaf8eeee938d3c824/regexes.yaml#L176
[^2]: https://github.com/ua-parser/uap-core/blob/959e106754828ae557b0dbcfaf8eeee938d3c824/regexes.yaml#L155
    @masklinn
    masklinn committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    970cc5a View commit details
    Browse the repository at this point in the history