Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.deployment updates #3364

Closed
wants to merge 31 commits into from

Conversation

ConnorSheremeta
Copy link
Contributor

@ConnorSheremeta ConnorSheremeta commented Feb 1, 2024

This now builds, with help from the webpacker migration to esbuild resolving font-awesome issues (which this is currently based on, will rebase once that is merged), with the following unresolved warnings:
A bootstrap upgrade to at least 5.3.2 (currently on 4.6.2) is required to resolve this deprecation warning
(https://blog.getbootstrap.com/2023/09/14/bootstrap-5-3-2/). Ticket: #3366

DEPRECATION WARNING: Passing percentage units to the global abs() function is deprecated.
In the future, this will emit a CSS abs() function to be resolved by the browser.
To preserve current behavior: math.abs(100%)
To emit a CSS abs() now: abs(#{100%})
More info: https://sass-lang.com/d/abs-percent

╷
│   $dividend: abs($dividend);
│              ^^^^^^^^^^^^^^
╵
node_modules/bootstrap/scss/vendor/_rfs.scss 54:14             divide()
node_modules/bootstrap/scss/mixins/_grid.scss 66:15            row-cols()
node_modules/bootstrap/scss/mixins/_grid-framework.scss 43:13  @content
node_modules/bootstrap/scss/mixins/_breakpoints.scss 65:5      media-breakpoint-up()
node_modules/bootstrap/scss/mixins/_grid-framework.scss 32:5   make-grid-columns()
#node_modules/bootstrap/scss/_grid.scss 72:3                    @import
bootstrap/scss/bootstrap.scss 16:9                             @import
app/assets/stylesheets/application.sass.scss 7:9               root stylesheet

Running esbuild app/javascript/*.* --bundle --sourcemap --outdir=app/assets/builds --public-path=/assets gives these warnings but they should be resolved upstream eventually:

WARN -- : Removed sourceMappingURL comment for missing asset '/assets/admin.js.map' from /app/app/assets/builds/admin.js
WARN -- : Removed sourceMappingURL comment for missing asset '/assets/application.js.map' from /app/app/assets/builds/application.js

RUN curl -sL https://deb.nodesource.com/setup_16.x | bash -
Causes this script deprecation warning: (Ticket: #3367)

This script, located at https://deb.nodesource.com/setup_X, used to
install Node.js is deprecated now and will eventually be made inactive.

Please visit the NodeSource distributions Github and follow the
instructions to migrate your repo.
https://github.com/nodesource/distributions

The NodeSource Node.js Linux distributions GitHub repository contains
information about which versions of Node.js and which Linux distributions
are supported and how to install it.
https://github.com/nodesource/distributions

Which is slightly misleading. We will need to move off of node 16 to resolve this as it is no longer supported or possibly move away from it all together through import maps.

murny and others added 30 commits January 8, 2024 17:50
Copy link

github-actions bot commented Feb 1, 2024

1 Warning
⚠️ This PR is too big! Consider breaking it down into smaller PRs.

Generated by 🚫 Danger

@pgwillia
Copy link
Member

pgwillia commented Mar 6, 2024

Was solved in #3320

@pgwillia pgwillia closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants