Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Tag Manager #582

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

exlame
Copy link

@exlame exlame commented Mar 27, 2018

No description provided.

Copy link
Member

@xcompass xcompass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @exlame for your contribution. Just a minor change. Since there is a new delta file added, you need to increase the db version in core.php.

@exlame
Copy link
Author

exlame commented Apr 27, 2018

I increased the DB Version but I don't think it is working. I'm doing a fresh installation and it doesn't add the field.
Is there another thing to do?

@xcompass
Copy link
Member

xcompass commented Jun 5, 2018

@exlame sorry for the delay. For the fresh installation, I think you need to add the new field to https://github.com/ubc/iPeer/blob/master/app/config/sql/ipeer.sql and https://github.com/ubc/iPeer/blob/master/app/config/sql/ipeer_samples_data.sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants