Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ingestion of GCS SAs from files outside of auth config #368

Closed
wants to merge 2 commits into from

Conversation

Anton-Kalpakchiev
Copy link
Collaborator

Why
Currently, Kraken expects all authentication credentials for backend clients (e.g. S3 and GCS) to be in the .yaml config. This works well for S3 and other backends, whose authentication credentials are strings and thus can be easily inserted into a .yaml file. However, it does not work for clients like GCS, whose authentication credentials are whole files (e.g. GCS uses an "access_blob").

It would be more convenient to have the option of Kraken accepting a path to an access_blob that it could then parse, similar to how parsing the TLS config works.

What

  • Edit origin and build-index config parsing, such that the GCS auth config can be optionally parsed differently -- instead of providing service accounts in the .yaml config, a path (and a name) can be passed. Kraken will then read the file with the service account.
  • If GCS credentials are provided both through the .yaml config and as paths to files, the files have precedence.

@Anton-Kalpakchiev
Copy link
Collaborator Author

After discussion within the team, we decided this feature is not needed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant